Avoid using dynamic properties of Icinga\Web\View as arguments
#5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviks789
force-pushed
the
fix/phpstan-latest-errors
branch
2 times, most recently
from
fa2c836 to
7e41616
Compare
raviks789
changed the title
$queryIcinga\Web\View as argument
raviks789
changed the title
Icinga\Web\View as argumentIcinga\Web\View as argument
raviks789
force-pushed
the
fix/phpstan-latest-errors
branch
from
7e41616 to
bbb3c11
Compare
raviks789
changed the title
Icinga\Web\View as argumentIcinga\Web\View as arguments
raviks789
force-pushed
the
fix/phpstan-latest-errors
branch
from
bbb3c11 to
2d75c47
Compare
nilmerg
requested changes
Nov 4, 2024
nilmerg
approved these changes
Nov 4, 2024
nilmerg
force-pushed
the
fix/phpstan-latest-errors
branch
from
25255c2 to
22c3a55
Compare
|
Not merging now. Doesn't seem to address any phpstan notices at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the dynamic properties of
Icinga\Web\Viewcan be null, these properties must not be used as arguments for methods whose parameters are not nullable.