Added missing length bytes for AlgorithmID to otherInfo. #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello IdentityPython-team,
the key derivation for the Elliptic Curve Diffie-Hellman algorithms is not correctly working as intended in the RFC7518 (JWA) chapter 4.6.2. In reference to the National Institute of Standards and Technology publication NIST.SP.800-56Ar2 chapter 5.8.1.2.1., the "OtherInfo" parameter, used in the concat key derivation algorithm, should consist of bytes containing the length for each information to be assembled to the byte array. This length bytes are missing for the "AlgorithmID" information in the "extra.py" file. Please consider this request to fix the key derivation, as otherwise JWEs using Elliptic Curves cannot be processed.
Thanks and best regards,
Vincent Unsel