Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing length bytes for AlgorithmID to otherInfo. #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added missing length bytes for AlgorithmID to otherInfo. #90

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 4, 2019

Hello IdentityPython-team,

the key derivation for the Elliptic Curve Diffie-Hellman algorithms is not correctly working as intended in the RFC7518 (JWA) chapter 4.6.2. In reference to the National Institute of Standards and Technology publication NIST.SP.800-56Ar2 chapter 5.8.1.2.1., the "OtherInfo" parameter, used in the concat key derivation algorithm, should consist of bytes containing the length for each information to be assembled to the byte array. This length bytes are missing for the "AlgorithmID" information in the "extra.py" file. Please consider this request to fix the key derivation, as otherwise JWEs using Elliptic Curves cannot be processed.

Thanks and best regards,

Vincent Unsel

@rohe
Copy link
Contributor

rohe commented Sep 4, 2019

I will definitely consider this. Just have to figure out why a couple of tests break with your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant