Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre commit conf #882

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Pre commit conf #882

wants to merge 4 commits into from

Conversation

g-as
Copy link
Contributor

@g-as g-as commented Nov 15, 2022

Description

Following #877, I added a .pre-commit-config.yaml conf file & ran trivial lints (trailing whitespace + EOF fixers)

See https://pre-commit.ci/ to automate integration.

The feature or problem addressed by this PR
What your changes do and why you chose this solution

Checklist

  • Checked that no other issues or pull requests exist for the same issue/change
  • Added tests covering the new functionality
  • Updated documentation OR the change is too minor to be documented
  • Updated CHANGELOG.md OR changes are insignificant

@g-as g-as changed the title Feature/pre commit Pre commit conf Nov 15, 2022
c00kiemon5ter
c00kiemon5ter reviewed Nov 15, 2022
View reviewed changes
tests/extra_lines.crt Outdated




Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is formatted like this on purpose

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this just the one, or are there any others to watch out for?

@g-as g-as force-pushed the feature/pre-commit branch from 2b9814b to 21dc3b1 Compare November 15, 2022 12:37
@c00kiemon5ter c00kiemon5ter added the next-release should become part of the next release label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c00kiemon5ter c00kiemon5ter c00kiemon5ter left review comments

Assignees
No one assigned
Labels
next-release should become part of the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-as @c00kiemon5ter