Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct tooltips for Bookmarks and Downloads on the tray #1655

Merged
merged 2 commits into from
Dec 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/src/main/res/layout/tray.xml
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@
android:id="@+id/bookmarksButton"
style="@style/trayButtonMiddleTheme"
android:src="@drawable/ic_icon_bookmark"
android:tooltipText="@{viewmodel.currentContentType == ContentType.BOOKMARKS ? @string/close_library_tooltip : @string/open_library_tooltip}"
android:tooltipText="@{viewmodel.currentContentType == ContentType.BOOKMARKS ? @string/close_bookmarks_tooltip : @string/open_bookmarks_tooltip}"
app:activeMode="@{viewmodel.currentContentType == ContentType.BOOKMARKS}"
app:clipDrawable="@drawable/ic_icon_library_clip"
app:tooltipDensity="@dimen/tray_tooltip_density"
Expand All @@ -201,7 +201,7 @@
<com.igalia.wolvic.ui.views.UIButton
android:id="@+id/downloadsButton"
style="@style/trayButtonMiddleTheme"
android:tooltipText="@{viewmodel.currentContentType == ContentType.DOWNLOADS ? @string/close_library_tooltip : @string/open_library_tooltip}"
android:tooltipText="@{viewmodel.currentContentType == ContentType.DOWNLOADS ? @string/close_downloads_tooltip : @string/open_downloads_tooltip}"
app:tooltipDensity="@dimen/tray_tooltip_density"
app:tooltipPosition="bottom"
app:tooltipLayout="@layout/tooltip_tray"
Expand Down
6 changes: 0 additions & 6 deletions app/src/main/res/values-da/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1221,12 +1221,6 @@
<!-- This string is for the tooltip that appears when the user hovers over the 'Downloads' icon in the
tray and the Downloads view is closed. The button it labels, when pressed, closes the Downloads view. -->
<string name="close_downloads_tooltip">Luk Filhentninger</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, opens the library panel. -->
<string name="open_library_tooltip">Åbn arkiv</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, closes the Library panel. -->
<string name="close_library_tooltip">Luk arkiv</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'What's New' icon in the
Navigation Bar. The button it labels, when pressed, open the release notes page. -->
<string name="whats_new_tooltip">Nyheder</string>
Expand Down
8 changes: 0 additions & 8 deletions app/src/main/res/values-de/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1640,14 +1640,6 @@ um: <ul>%1$s</ul></p>]]></string>
tray and the Downloads view is closed. The button it labels, when pressed, closes the Downloads view. -->
<string name="close_downloads_tooltip">Downloads schließen</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, opens the library panel. -->
<string name="open_library_tooltip">Bibliothek öffnen</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, closes the Library panel. -->
<string name="close_library_tooltip">Bibliothek schließen</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'What's New' icon in the
Navigation Bar. The button it labels, when pressed, open the release notes page. -->
<string name="whats_new_tooltip">Was ist neu</string>
Expand Down
8 changes: 0 additions & 8 deletions app/src/main/res/values-en-rGB/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1691,14 +1691,6 @@
tray and the Downloads view is closed. The button it labels, when pressed, closes the Downloads view. -->
<string name="close_downloads_tooltip">Close Downloads</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, opens the library panel. -->
<string name="open_library_tooltip">Open Library</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, closes the Library panel. -->
<string name="close_library_tooltip">Close Library</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'What's New' icon in the
Navigation Bar. The button it labels, when pressed, open the release notes page. -->
<string name="whats_new_tooltip">What’s New</string>
Expand Down
6 changes: 0 additions & 6 deletions app/src/main/res/values-es-rES/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1222,12 +1222,6 @@
<!-- This string is for the tooltip that appears when the user hovers over the 'Downloads' icon in the
tray and the Downloads view is closed. The button it labels, when pressed, closes the Downloads view. -->
<string name="close_downloads_tooltip">Cerrar descargas</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, opens the library panel. -->
<string name="open_library_tooltip">Abrir biblioteca</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, closes the Library panel. -->
<string name="close_library_tooltip">Cerrar biblioteca</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'What's New' icon in the
Navigation Bar. The button it labels, when pressed, open the release notes page. -->
<string name="whats_new_tooltip">Novedades</string>
Expand Down
8 changes: 0 additions & 8 deletions app/src/main/res/values-es/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1675,14 +1675,6 @@
tray and the Downloads view is closed. The button it labels, when pressed, closes the Downloads view. -->
<string name="close_downloads_tooltip">Cerrar descargas</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, opens the library panel. -->
<string name="open_library_tooltip">Abrir biblioteca</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, closes the Library panel. -->
<string name="close_library_tooltip">Cerrar biblioteca</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'What's New' icon in the
Navigation Bar. The button it labels, when pressed, open the release notes page. -->
<string name="whats_new_tooltip">Novedades</string>
Expand Down
6 changes: 0 additions & 6 deletions app/src/main/res/values-fr/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1221,12 +1221,6 @@
<!-- This string is for the tooltip that appears when the user hovers over the 'Downloads' icon in the
tray and the Downloads view is closed. The button it labels, when pressed, closes the Downloads view. -->
<string name="close_downloads_tooltip">Fermer les téléchargements</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, opens the library panel. -->
<string name="open_library_tooltip">Ouvrir la bibliothèque</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, closes the Library panel. -->
<string name="close_library_tooltip">Fermer la bibliothèque</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'What's New' icon in the
Navigation Bar. The button it labels, when pressed, open the release notes page. -->
<string name="whats_new_tooltip">Nouveautés</string>
Expand Down
2 changes: 0 additions & 2 deletions app/src/main/res/values-gl/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,6 @@
<string name="open_downloads_tooltip">Abrir descargas</string>
<string name="close_history_tooltip">Pechar historial</string>
<string name="close_downloads_tooltip">Pechar descargas</string>
<string name="open_library_tooltip">Abrir biblioteca</string>
<string name="close_library_tooltip">Pechar biblioteca</string>
<string name="whats_new_tooltip">Novidades</string>
<string name="remove_all">Borrar todo</string>
<string name="homepage_hint">Páxina de inicio de %1$s (por defecto)</string>
Expand Down
8 changes: 0 additions & 8 deletions app/src/main/res/values-it/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1638,14 +1638,6 @@
tray and the Downloads view is closed. The button it labels, when pressed, closes the Downloads view. -->
<string name="close_downloads_tooltip">Chiudi l’elenco dei download</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, opens the library panel. -->
<string name="open_library_tooltip">Apri Libreria</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, closes the Library panel. -->
<string name="close_library_tooltip">Chiudi Libreria</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'What's New' icon in the
Navigation Bar. The button it labels, when pressed, open the release notes page. -->
<string name="whats_new_tooltip">Novità</string>
Expand Down
6 changes: 0 additions & 6 deletions app/src/main/res/values-ja/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1218,12 +1218,6 @@
<!-- This string is for the tooltip that appears when the user hovers over the 'Downloads' icon in the
tray and the Downloads view is closed. The button it labels, when pressed, closes the Downloads view. -->
<string name="close_downloads_tooltip">ダウンロードリストを閉じます</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, opens the library panel. -->
<string name="open_library_tooltip">ライブラリーを開く</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, closes the Library panel. -->
<string name="close_library_tooltip">ライブラリーを閉じる</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'What's New' icon in the
Navigation Bar. The button it labels, when pressed, open the release notes page. -->
<string name="whats_new_tooltip">新着情報</string>
Expand Down
6 changes: 0 additions & 6 deletions app/src/main/res/values-ko/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1220,12 +1220,6 @@
<!-- This string is for the tooltip that appears when the user hovers over the 'Downloads' icon in the
tray and the Downloads view is closed. The button it labels, when pressed, closes the Downloads view. -->
<string name="close_downloads_tooltip">다운로드 닫기</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, opens the library panel. -->
<string name="open_library_tooltip">라이브러리 열기</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, closes the Library panel. -->
<string name="close_library_tooltip">라이브러리 닫기</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'What's New' icon in the
Navigation Bar. The button it labels, when pressed, open the release notes page. -->
<string name="whats_new_tooltip">새 기능</string>
Expand Down
8 changes: 0 additions & 8 deletions app/src/main/res/values-nb-rNO/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1641,14 +1641,6 @@
tray and the Downloads view is closed. The button it labels, when pressed, closes the Downloads view. -->
<string name="close_downloads_tooltip">Lukk nedlastinger</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, opens the library panel. -->
<string name="open_library_tooltip">Åpne bibliotek</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, closes the Library panel. -->
<string name="close_library_tooltip">Lukk bibliotek</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'What's New' icon in the
Navigation Bar. The button it labels, when pressed, open the release notes page. -->
<string name="whats_new_tooltip">Hva er nytt</string>
Expand Down
8 changes: 0 additions & 8 deletions app/src/main/res/values-nl/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1644,14 +1644,6 @@
tray and the Downloads view is closed. The button it labels, when pressed, closes the Downloads view. -->
<string name="close_downloads_tooltip">Downloads sluiten</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, opens the library panel. -->
<string name="open_library_tooltip">Bibliotheek openen</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, closes the Library panel. -->
<string name="close_library_tooltip">Bibliotheek sluiten</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'What's New' icon in the
Navigation Bar. The button it labels, when pressed, open the release notes page. -->
<string name="whats_new_tooltip">Wat is er nieuw</string>
Expand Down
8 changes: 0 additions & 8 deletions app/src/main/res/values-nn-rNO/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1641,14 +1641,6 @@
tray and the Downloads view is closed. The button it labels, when pressed, closes the Downloads view. -->
<string name="close_downloads_tooltip">Lat att nedlastingar</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, opens the library panel. -->
<string name="open_library_tooltip">Opne biblioteket</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, closes the Library panel. -->
<string name="close_library_tooltip">Lat att biblioteket</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'What's New' icon in the
Navigation Bar. The button it labels, when pressed, open the release notes page. -->
<string name="whats_new_tooltip">Kva er nytt</string>
Expand Down
8 changes: 0 additions & 8 deletions app/src/main/res/values-pl/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1641,14 +1641,6 @@
tray and the Downloads view is closed. The button it labels, when pressed, closes the Downloads view. -->
<string name="close_downloads_tooltip">Zamknij listę pobranych plików</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, opens the library panel. -->
<string name="open_library_tooltip">Otwórz bibliotekę</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, closes the Library panel. -->
<string name="close_library_tooltip">Zamknij bibliotekę</string>

<!-- This string is for the tooltip that appears when the user hovers over the 'What's New' icon in the
Navigation Bar. The button it labels, when pressed, open the release notes page. -->
<string name="whats_new_tooltip">Co nowego</string>
Expand Down
2 changes: 0 additions & 2 deletions app/src/main/res/values-pt-rBR/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -312,9 +312,7 @@
<string name="context_menu_web_search">Pesquisar com %1$s</string>
<string name="bookmark_tooltip">Favoritar esta página</string>
<string name="open_bookmarks_tooltip">Abrir favoritos</string>
<string name="open_library_tooltip">Biblioteca aberta</string>
<string name="remove_all">Deletar tudo</string>
<string name="close_library_tooltip">Fechar biblioteca</string>
<string name="close_downloads_tooltip">Fechar downloads</string>
<string name="homepage_hint">%1$s Início (Padrão)</string>
<string name="max_windows_msg">Apenas janelas %1$s podem ser abertas. Feche uma para abrir outra.</string>
Expand Down
2 changes: 0 additions & 2 deletions app/src/main/res/values-pt/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@
<string name="close_history_tooltip">Fechar histórico</string>
<string name="open_downloads_tooltip">Abrir descargas</string>
<string name="close_downloads_tooltip">Fechar descargas</string>
<string name="close_library_tooltip">Fechar biblioteca</string>
<string name="private_browsing_body">&lt;p&gt;Quando navega numa janela privada, %1$s &lt;strong&gt;não salva&lt;/strong&gt;:&lt;/p&gt; &lt;ul class=two-column&gt; &lt;li&gt;páginas visitadas&lt;/li&gt; &lt;li&gt;pesquisas&lt;/li&gt; &lt;li&gt;cookies&lt;/li&gt; &lt;li&gt;ficheiros temporários&lt;/li&gt; &lt;/ul&gt; &lt;p&gt;Navegação privada &lt;strong&gt;não o torna anônimo&lt;/strong&gt; na Internet. O seu empregador ou provedor de serviços de Internet ainda pode saber qual página visita.&lt;/p&gt; &lt;p class=about-info&gt;Saiba mais sobre &lt;a id=learnMore&gt;Navegação privada&lt;/a&gt;.&lt;/p&gt;</string>
<string name="authentication_username">Nome de utilizador:</string>
<string name="authentication_password">Palavra-passe:</string>
Expand Down Expand Up @@ -607,7 +606,6 @@
<string name="col_date_last_modified">Última modificação</string>
<string name="back_tooltip">Voltar</string>
<string name="context_menu_copy_link">Copiar ligação</string>
<string name="open_library_tooltip">Abrir biblioteca</string>
<string name="private_browsing_title">Navegação privada</string>
<string name="no_internet_message">Verifique a configuração do aparelho para corrigir o problema.</string>
<string name="tabs_selected_counter_plural">%1$s guias selecionadas</string>
Expand Down
6 changes: 0 additions & 6 deletions app/src/main/res/values-ru/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1218,12 +1218,6 @@
<!-- This string is for the tooltip that appears when the user hovers over the 'Downloads' icon in the
tray and the Downloads view is closed. The button it labels, when pressed, closes the Downloads view. -->
<string name="close_downloads_tooltip">Закрыть загрузки</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, opens the library panel. -->
<string name="open_library_tooltip">Открыть библиотеку</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'Library' icon in the
tray and the Library view is closed. The button it labels, when pressed, closes the Library panel. -->
<string name="close_library_tooltip">Закрыть библиотеку</string>
<!-- This string is for the tooltip that appears when the user hovers over the 'What's New' icon in the
Navigation Bar. The button it labels, when pressed, open the release notes page. -->
<string name="whats_new_tooltip">Что нового</string>
Expand Down
Loading
Loading