-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling dependencies, documentation, and modularity through an R package #96
Open
MansMeg
wants to merge
16
commits into
ImperialCollegeLondon:master
Choose a base branch
from
MansMeg:origin_repo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update origin repo
Sorry for all commits in this PR, it was a little tricky to get the R package to build on Docker. That is now solved. |
MansMeg
changed the title
Handling dependency and functionality through an R package
Handling dependencies, documentation, and modularity through an R package
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I realized that you in your version 3 had already factorized a lot of the code I also had refactored so submitting that would not help much. Rather I will try to adapt to your structure. The only difference is that I included my refactored R code in an R package to handle dependencies and enable simple reuse of your code. It also gives a simple way to document the functionality.
I suggest that the current functionality hence is included in a project-specific R package. The difference is very small, although it simplifies further development by others as well as it enables automated test suites for the refactored code.
In this PR I only included the functions in the
utils/
folder. Locally I also have refactored functions for the plotting functions that could be included as well.I now put myself as a package author and maintainer. I could happily put someone else. I also put the exact same LICENSE for the R package.
This PR will also solve the issue in PR #88 since dependencies will be handling by Rs package infrastructure.