Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling dependencies, documentation, and modularity through an R package #96

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

MansMeg
Copy link
Contributor

@MansMeg MansMeg commented May 1, 2020

Hi!

I realized that you in your version 3 had already factorized a lot of the code I also had refactored so submitting that would not help much. Rather I will try to adapt to your structure. The only difference is that I included my refactored R code in an R package to handle dependencies and enable simple reuse of your code. It also gives a simple way to document the functionality.

I suggest that the current functionality hence is included in a project-specific R package. The difference is very small, although it simplifies further development by others as well as it enables automated test suites for the refactored code.

In this PR I only included the functions in the utils/ folder. Locally I also have refactored functions for the plotting functions that could be included as well.

I now put myself as a package author and maintainer. I could happily put someone else. I also put the exact same LICENSE for the R package.

This PR will also solve the issue in PR #88 since dependencies will be handling by Rs package infrastructure.

@MansMeg MansMeg marked this pull request as draft May 1, 2020 15:24
@MansMeg MansMeg marked this pull request as ready for review May 1, 2020 17:50
@MansMeg
Copy link
Contributor Author

MansMeg commented May 1, 2020

Sorry for all commits in this PR, it was a little tricky to get the R package to build on Docker. That is now solved.

@MansMeg MansMeg changed the title Handling dependency and functionality through an R package Handling dependencies, documentation, and modularity through an R package May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant