-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merging develop into main for v2.2 #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove library as it is unused and might cause problems with Travis
- nonlifting_body_grid contains similiar to Aerogrid all information of the grid of panels but for nonlifting bodies/surfaces instead of lifting surfaces - grid class serves as a parent class from which nonlifting_body_grid is inheritated from, and later also Aerogrid
- NonliftingBodyTimeStepInfo is similar to AeroTimestepInfo but contains the relevant aerodynamic attributes for a single time step for nonlifting bodies instead of nonlifting surfaces - Its parent class TimeStepInfo will later also be used as a parent class for AeroTimeStepInfo
- functionality of class remains unchanged
- functionality of Aerogrid class remains unchanged - rename attributes for proper inheritance
- Nodes position are first calculate in B frame and are then converted to the A frame - add necessary and delete unnecessary imported packages
- Gridloader acts as a parent class for nonliftingbodygridloader class - Nonliftingbodygridloader generates aerodynamic grid for nonlifitng bodies similiar to aerogrid
- allows to simplify AerogridTimeStepInfo as a side effect since the array dimensions align with NonliftingBodyTimeStepInfo now
- Delete functions that are no longer needed since zeta contains only grid nodes instead of collocation points
- new function starts different UVLM function to calculate nonlifting bodies
- Velocity generator for Lifting surfaces is only called if no nonlifting bodies are analyzed. Otherwise it gives zero uext-arrays to the nonlifting body VLM solver.
- necessary since the introduced gridloader class the attribute was renamed
…ment Update docker environment
New Fuselage Model plus Minor Improvements
…ment fix [docker] use correct environment name in docker bashrc
fix polars concatenation in assembly of aeroinformation - develop
Old MacOS environment is to be replaced with the new environment
Environment not needed - replaced with environment_new.yml
Added environment for Apple Silicon (ARM64)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you all for contributing to v2.2!