Build: Add Support of cover image for pages and also grid view for list of pages #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in chapter show page with test case and update create test case for page and add two test case one for update cover image for page and another for reset cover image for page
munir131
reviewed
Oct 25, 2024
app/Entities/Models/Page.php
Outdated
|
|
||
| public function getPageCover(int $width = 440, int $height = 250): string | ||
| { | ||
| $default = 'data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw=='; |
There was a problem hiding this comment.
@brijm-improwised default should be configurable using env
There was a problem hiding this comment.
They implement this for book and for book they give this way only
that why i give this way
There was a problem hiding this comment.
book they give this way only - @brijm-improwised Can you give example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue : Support Page Cover Images and Page Grid View
Closes #18
Changes proposed
update time
- Note That : At time of create page if you save draft then cover image will not save
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers