Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add FreeBSD and NetBSD platforms #19

Merged
merged 2 commits into from
Oct 29, 2023
Merged

feat: add FreeBSD and NetBSD platforms #19

merged 2 commits into from
Oct 29, 2023

Conversation

kbdharun
Copy link
Contributor

@kbdharun kbdharun commented Oct 29, 2023 •
edited
Loading

Changes

  • Support for the newly added "FreeBSD" and "NetBSD" platforms. (Currently, there is only 1 page in each of the platforms, we are working on adding more in the future.)
  • Arrange the platforms in alphabetical order.

This PR marks the completion of adding support for all major BSD platforms that I started with #18

Reference Images

Screenshot from 2023-10-29 16-15-30
Screenshot from 2023-10-29 16-15-49
Screenshot from 2023-10-29 16-16-06

Checklist

  • Tested the changes locally with npm run dev and in production with npm run build.

@kbdharun
feat: add FreeBSD and NetBSD platforms
24dc10d 
Signed-off-by: K.B.Dharun Krishna <[email protected]>
@kbdharun
cleanup: arrange platforms list
4851543 
Signed-off-by: K.B.Dharun Krishna <[email protected]>
@kbdharun kbdharun mentioned this pull request Oct 29, 2023
Closed
70 tasks
@rwv
Copy link
Contributor

rwv commented Oct 29, 2023

I prefer to arrange the platforms in platform's page count order. What do you think?

@kbdharun
Copy link
Contributor Author

I prefer to arrange the platforms in platform's page count order. What do you think?

Sure, feel free to update the branch as you prefer.

@rwv rwv merged commit 11ff0e6 into InBrowserApp:main Oct 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbdharun @rwv