fix Aspects exclude is true if one Aspects is empty

Inari-Soft · Nov 17, 2016 · 9346513 · 9346513
1 parent 73aeb67
commit 9346513
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/com/inari/commons/lang/aspect/Aspects.java b/src/main/java/com/inari/commons/lang/aspect/Aspects.java
@@ -78,7 +78,7 @@ public final boolean include( Aspects aspects ) {
     public final boolean exclude( Aspects aspects ) {
         checkType( aspects );
         if ( bitset.isEmpty() || aspects.bitset.isEmpty() ) {
-            return false;
+            return true;
         }
 
         if ( this == aspects ) {

diff --git a/src/test/java/com/inari/commons/lang/aspect/AspectsTest.java b/src/test/java/com/inari/commons/lang/aspect/AspectsTest.java
@@ -96,9 +96,9 @@ public void testExclude() {
         Aspects aspect3 = aspectGroup.createAspects();
         Aspects aspect4 = aspectGroup.createAspects();
 
-        assertFalse( aspect1.exclude( aspect2 ) );
-        assertFalse( aspect2.exclude( aspect3 ) );
-        assertFalse( aspect4.exclude( aspect4 ) );
+        assertTrue( aspect1.exclude( aspect2 ) );
+        assertTrue( aspect2.exclude( aspect3 ) );
+        assertTrue( aspect4.exclude( aspect4 ) );
 
         aspect1.bitset.set( 1 );
         aspect1.bitset.set( 3 );