-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented GET /1/stats/release-group/(release_group_mbid)/listeners #23
Implemented GET /1/stats/release-group/(release_group_mbid)/listeners #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one nitpick. Otherwise fine.
Finally, commits need to be documented a bit more. Currently, they're just one-liners with no justification or detail. The PR desc could be improved too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
And fixed the .gitignore. |
Commits should be squashed into one. Same as #24:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commits to be squashed. See here.
14e80cb
to
d897d22
Compare
This should be fine. It's the first time I did a Rebase and Squash like this so I hope I didn't mess up anything |
Rebase is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than what I've commented on, it's okay. Ideally I'd like more descriptive commit messages, but I guess it's not too importrant.
Added stats_release_group_listeners() on the raw client. Added the endpoint information to the enum. Added StatsReleaseGroupListenersResponse, StatsReleaseGroupListenersPayload and StatsReleaseGroupListenersListeners as responce models
d897d22
to
63a1b0c
Compare
Remove the .gitiignore change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR - and putting up with my nitpicks!
Recreation of #20 due to accidental commits