Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 1.20.2 #2431

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Add support for 1.20.2 #2431

merged 3 commits into from
Sep 29, 2023

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Sep 23, 2023 •
edited
Loading

TODO:

  • Update refractions
  • Regen
  • Testing

@NotMyFault NotMyFault added the Major feature This PR adds a major feature label Sep 23, 2023
@NotMyFault NotMyFault requested a review from a team as a code owner September 23, 2023 14:49
@TheMeinerLP
Copy link
Member

I have still not tested! But i will do

@MattBDev
Copy link
Contributor

Looks good. If tests come back as all working I approve.

@PierreSchwang PierreSchwang self-requested a review September 29, 2023 18:40
PierreSchwang
PierreSchwang approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@PierreSchwang PierreSchwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regen works fine so far, Entity-Copy works as well. I think that should cover the bits that are important

@NotMyFault NotMyFault enabled auto-merge (squash) September 29, 2023 19:50
@NotMyFault NotMyFault merged commit 45b60f4 into main Sep 29, 2023
6 checks passed
@NotMyFault NotMyFault deleted the 1.20.2 branch September 29, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreSchwang PierreSchwang PierreSchwang approved these changes

@x9nico x9nico x9nico approved these changes

@TheMeinerLP TheMeinerLP TheMeinerLP approved these changes

Assignees
No one assigned
Labels
Major feature This PR adds a major feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NotMyFault @TheMeinerLP @MattBDev @x9nico @PierreSchwang