Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.17.1] Native Adapter improvements #2433

Conversation

TheMeinerLP
Copy link
Member

Overview

This PR improve readability, error handling and code consistency.

Description

Submitter Checklist

Preview Give feedback

@github-actions github-actions bot added the Feature This PR adds a new feature label Sep 26, 2023
@TheMeinerLP TheMeinerLP marked this pull request as ready for review September 26, 2023 13:07
@TheMeinerLP TheMeinerLP requested a review from a team as a code owner September 26, 2023 13:07
@NotMyFault
Copy link
Member

Upstream structure changes should ultimately be PRed to upstream.

@TheMeinerLP
Copy link
Member Author

Upstream structure changes should ultimately be PRed to upstream.

Some instruction how can easily do that ?
I had also planned for 1.18.2-1.20.2

@NotMyFault
Copy link
Member

Ask upstream whether they are interested in such a change. If they aren't, we likely won't accept it either, to keep the maintenance diff as small as possible, especially for upstream classes.

@TheMeinerLP
Copy link
Member Author

Will not be accepted at all.

@TheMeinerLP TheMeinerLP deleted the feature/adapter/cleanup-1.17.1 branch September 26, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants