Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make exit_flag verification for ascend more general #2588

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

CyCle1024
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

As some developers would develop custom device_type for Ascend npu, it's better to resolve the exit problem with tp > 2 on ascend platform with more general check instead of device_type =='ascend'. We change this behavior into checking with we have already imported 'torch_npu' module.

Modification

Change an if-branch condition to make it more general.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CyCle1024 CyCle1024 linked an issue Oct 11, 2024 that may be closed by this pull request
3 tasks
@CyCle1024 CyCle1024 force-pushed the ccy/exit_flag_check branch from 79e6261 to 8ac3b3f Compare October 12, 2024 10:36
@lvhan028 lvhan028 merged commit 88eccb2 into InternLM:main Oct 14, 2024
5 checks passed
@CyCle1024 CyCle1024 deleted the ccy/exit_flag_check branch October 14, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to use Ctrl+C to normally end service on the Ascend platform
3 participants