Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add params config for api server web_ui #735

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

amulil
Copy link
Contributor

@amulil amulil commented Nov 22, 2023

Motivation

the current api server web demo is simple, I want to change some params on the web.

Modification

Just add three new params top_ptemperatureMaximum new tokens(request_output_len in the code)
截屏2023-11-22 18 34 52

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues. —— Already run.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness. —— I test the code change by changing the params value and then observe the model output, I think the output is right.

@lvhan028 lvhan028 added the enhancement New feature or request label Nov 23, 2023
Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @amulil Sorry for the late reply. Would you mind making the same change to turbomind backend and triton server backend for the WebUI?

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon
Copy link
Collaborator

Hope we can use same ui for gradio as the backend or as pure frontend.

@amulil
Copy link
Contributor Author

amulil commented Dec 15, 2023

Hi, @amulil Sorry for the late reply. Would you mind making the same change to turbomind backend and triton server backend for the WebUI?

OK, I will do it this weekend.

@AllentDan I finish it. And run pre-commit.

@amulil amulil requested a review from AllentDan December 19, 2023 03:16
Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit ba777b9 into InternLM:main Dec 20, 2023
3 checks passed
@amulil amulil deleted the add_web_params branch December 21, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants