Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable attention mask when it is not needed #813

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Disable attention mask when it is not needed #813

merged 2 commits into from
Dec 11, 2023

Conversation

lzhangzz
Copy link
Collaborator

No description provided.

@lvhan028 lvhan028 requested review from grimoire and irexyc December 11, 2023 03:03
@irexyc
Copy link
Collaborator

irexyc commented Dec 11, 2023

Will there be any problems when use_context_fmha = 1 and sm < 80?

grimoire
grimoire approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit b8354da into InternLM:main Dec 11, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irexyc irexyc irexyc approved these changes

@grimoire grimoire grimoire approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzhangzz @irexyc @grimoire @lvhan028