Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stable api_server benchmark result by a non-zero await #885

Merged
merged 2 commits into from
Dec 25, 2023
Merged

stable api_server benchmark result by a non-zero await #885

merged 2 commits into from
Dec 25, 2023

Conversation

AllentDan
Copy link
Collaborator

await asyncio.sleep(0) makes the coroutine switch too fast, making the server benchmark unstable.

zhulinJulia24
zhulinJulia24 approved these changes Dec 25, 2023
View reviewed changes
Copy link
Collaborator

@zhulinJulia24 zhulinJulia24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lvhan028
lvhan028 approved these changes Dec 25, 2023
View reviewed changes
Copy link
Collaborator

@lvhan028 lvhan028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit e84e99a into InternLM:main Dec 25, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhulinJulia24 zhulinJulia24 zhulinJulia24 approved these changes

@lvhan028 lvhan028 lvhan028 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AllentDan @lvhan028 @zhulinJulia24