Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searchbar changes to include prefix #433

Closed

Conversation

Yh010
Copy link
Contributor

@Yh010 Yh010 commented Apr 6, 2023

Searchbar changes to include prefix #252 . In continuation to #307

@Yh010 Yh010 changed the title changes Searchbar changes to include prefix Apr 6, 2023
@Yh010 Yh010 marked this pull request as draft April 6, 2023 10:04
@Yh010 Yh010 marked this pull request as ready for review April 7, 2023 12:59
Copy link
Member

@roopeshsn roopeshsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the html and js files. You can remove those. Also, make sure to run the code locally and ensure that the page is routed to the prefix when searched.

<q-item-section side color="accent"> Country </q-item-section>
<q-item-section class="IHR_asn-element-name">{{ scope.opt.name }}</q-item-section>
</q-item>
<q-item>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The q-item tag shouldn't be closed.

@dpgiakatos
Copy link
Member

This pull request is identical to the one at #429. As PR #429 is still active and older, I am closing this duplicate pull request.

@dpgiakatos dpgiakatos closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants