Bootstrap Peers #5485
Closed
Bootstrap Peers #5485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolt12
force-pushed
the
bolt12/bootstrapPeers
branch
from
8d4ac7c to
b1adda8
Compare
bolt12
commented
Sep 27, 2023
bolt12
force-pushed
the
bolt12/bootstrapPeers
branch
from
b1adda8 to
f0938b7
Compare
|
This PR is stale because it has been open 45 days with no activity. |
bolt12
force-pushed
the
bolt12/bootstrapPeers
branch
from
f0938b7 to
8568962
Compare
|
This PR is stale because it has been open 45 days with no activity. |
bolt12
force-pushed
the
bolt12/bootstrapPeers
branch
3 times, most recently
from
4c6c551 to
ed19a94
Compare
bolt12
force-pushed
the
bolt12/bootstrapPeers
branch
7 times, most recently
from
bf2ad5b to
c9fd4bd
Compare
bolt12
force-pushed
the
bolt12/bootstrapPeers
branch
from
2019cb9 to
800148d
Compare
bolt12
force-pushed
the
bolt12/bootstrapPeers
branch
3 times, most recently
from
a84e07a to
5276ca7
Compare
bolt12
force-pushed
the
bolt12/bootstrapPeers
branch
from
5276ca7 to
14180fc
Compare
bolt12
force-pushed
the
bolt12/bootstrapPeers
branch
4 times, most recently
from
ed7040f to
8419b9c
Compare
coot
reviewed
Feb 15, 2024
bolt12
force-pushed
the
bolt12/bootstrapPeers
branch
2 times, most recently
from
f5dbe65 to
1895d23
Compare
bolt12
force-pushed
the
bolt12/bootstrapPeers
branch
2 times, most recently
from
b2e3fe3 to
0efc013
Compare
coot
reviewed
Feb 23, 2024
| } = | ||
| ( map (\lrp -> ( hotValency lrp | ||
| , warmValency lrp | ||
| , Map.fromList $ map (fmap (, trustable lrp)) |
There was a problem hiding this comment.
This is a bit ugly that we need to add this information this way. We cannot simply extend RootConfig because that type is used in various places. A nicer way would be to provide LocalRootConfig type:
data LocalRootConfig = LocalRootConfig
{ localRootAccessPoints :: [RelayAccessPoint]
-- ^ a list of relay access points, each of which is either an ip address
-- or domain name and a port number.
, localRootAdvertise :: PeerAdvertise,
-- ^ 'advertise' configures whether the root should be advertised through
-- gossip.
, localRootTrustable :: Bool
-- ^ ...
} deriving (Eq, Show)
bolt12
force-pushed
the
bolt12/bootstrapPeers
branch
from
0efc013 to
a1042b4
Compare
|
Yes, my bad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates: IntersectMBO/ouroboros-network#4555