Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Conway protocol version to 10 #6009

Closed

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Oct 10, 2024

Description

  • Set Conway protocol version to 10
  • ExperimentalHardForksEnabled currently has no effect

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@Jimbo4350 Jimbo4350 changed the title WIP Set Conway protocol version to 10 Oct 10, 2024
@Jimbo4350 Jimbo4350 marked this pull request as ready for review October 10, 2024 19:17
@Jimbo4350 Jimbo4350 requested a review from a team as a code owner October 10, 2024 19:17
@Jimbo4350 Jimbo4350 force-pushed the jordan/remove-experimental-hardforks-switch branch from f463930 to 6fbc42c Compare October 15, 2024 16:05
@Jimbo4350
Copy link
Contributor Author

Jimbo4350 commented Oct 15, 2024

The change is already in the node release.

@Jimbo4350 Jimbo4350 closed this Oct 15, 2024
@Jimbo4350 Jimbo4350 deleted the jordan/remove-experimental-hardforks-switch branch October 28, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants