Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-testnet | Remove NodeRuntime type #6013

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Oct 14, 2024

Description

Removes NodeRuntime type, which was redundant.

A follow up from #6007 (comment)

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer force-pushed the mgalazyn/chore/remove-noderuntime-type branch 2 times, most recently from 54e0bcd to 88ad784 Compare October 14, 2024 18:02
@carbolymer carbolymer marked this pull request as ready for review October 14, 2024 18:04
@carbolymer carbolymer requested a review from a team as a code owner October 14, 2024 18:04
@carbolymer carbolymer force-pushed the mgalazyn/chore/remove-noderuntime-type branch from 88ad784 to 23af7d0 Compare October 14, 2024 19:23
@smelc
Copy link
Contributor

smelc commented Oct 14, 2024

There are imports to remove.

@carbolymer carbolymer force-pushed the mgalazyn/chore/remove-noderuntime-type branch from 23af7d0 to 1a59399 Compare October 15, 2024 08:10
@carbolymer carbolymer force-pushed the mgalazyn/chore/remove-noderuntime-type branch from 1a59399 to b0d8411 Compare October 15, 2024 08:17
@carbolymer carbolymer enabled auto-merge October 15, 2024 08:24
@carbolymer carbolymer added this pull request to the merge queue Oct 15, 2024
Merged via the queue into master with commit 959eb8e Oct 15, 2024
23 of 24 checks passed
@carbolymer carbolymer deleted the mgalazyn/chore/remove-noderuntime-type branch October 15, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants