Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Patching Overlay Mode #603

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peter-power-594
Copy link

Greetings @Ionaru

This feedback is about a bug fix I guess.

I'm not a rock star with CodeMirror combined modes and tokens stuff so my patch might not be relevant at all - in this case sorry in advance 😝- from what I understand with the the current options, the custom overlay-mode is overwritten by the spell-checker mode - so disabled actually 😅- if the spell checker is set to true.

It's about an if / else snippet so there are various ways to patch it... And damage other setups if not done properly 💦
This patch works for me. Feel free to check and play with the demo page. 😉

Best regards,

Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant