Skip to content

Commit

Permalink
fix: Use correct sha1 hashing algo for wsse auth
Browse files Browse the repository at this point in the history
  • Loading branch information
Its-treason committed Oct 2, 2024
1 parent 4b97ca4 commit 634c07d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions packages/bruno-core/src/request/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ environment variables, the collection and the request itself. The Context is
passed to everything function and updated throughout the request execution by
reference.

Bigger files with more functions are best read from bottom to top. The "entrypoint" or
exported function mostly on the bottom of the files and function at the top are
called later from the entrypoint or from other function within. All files
(except `createHttpRequest.ts`) only export one function.

The code is structured in different folder based on when its used in the request
process.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function generateWSSEHeader(username: string, password: string): string {
const created = new Date().toISOString();

// Generate the password digest
const passwordDigest = createHash('sha256')
const passwordDigest = createHash('sha1')
.update(nonce + created + password)
.digest('base64');

Expand Down

1 comment on commit 634c07d

@dwolter-emarsys
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Its-treason , heads up that there were a few more changes I needed to correct for wsse to work again:

usebruno@077a0f9

Cheers,
Dylan

Please sign in to comment.