This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 716
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'Ivy-Apps:main' into fix-issue-3565
- Loading branch information
Showing
8 changed files
with
136 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
shared/ui/core/src/main/java/com/ivy/ui/FormatMoneyUseCase.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package com.ivy.ui | ||
|
|
||
| import android.content.Context | ||
| import com.ivy.domain.features.Features | ||
| import com.ivy.ui.time.DevicePreferences | ||
| import dagger.hilt.android.qualifiers.ApplicationContext | ||
| import java.text.DecimalFormat | ||
| import java.text.DecimalFormatSymbols | ||
| import javax.inject.Inject | ||
|
|
||
| class FormatMoneyUseCase @Inject constructor( | ||
| private val features: Features, | ||
| private val devicePreferences: DevicePreferences, | ||
| @ApplicationContext private val context: Context | ||
| ) { | ||
|
|
||
| private val locale = devicePreferences.locale() | ||
| private val withoutDecimalFormatter = DecimalFormat("###,###", DecimalFormatSymbols(locale)) | ||
| private val withDecimalFormatter = DecimalFormat("###,###.00", DecimalFormatSymbols(locale)) | ||
|
|
||
| suspend fun format(value: Double): String { | ||
| val showDecimalPoint = features.showDecimalNumber.isEnabled(context) | ||
|
|
||
| return when (showDecimalPoint) { | ||
| true -> withDecimalFormatter.format(value) | ||
| false -> withoutDecimalFormatter.format(value) | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
shared/ui/core/src/test/java/com/ivy/ui/FormatMoneyUseCaseTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| package com.ivy.ui | ||
|
|
||
| import android.content.Context | ||
| import com.google.testing.junit.testparameterinjector.TestParameter | ||
| import com.google.testing.junit.testparameterinjector.TestParameterInjector | ||
| import com.ivy.domain.features.Features | ||
| import com.ivy.ui.time.DevicePreferences | ||
| import io.kotest.common.runBlocking | ||
| import io.kotest.matchers.shouldBe | ||
| import io.mockk.coEvery | ||
| import io.mockk.every | ||
| import io.mockk.mockk | ||
| import org.junit.Test | ||
| import org.junit.runner.RunWith | ||
| import java.util.Locale | ||
|
|
||
| @RunWith(TestParameterInjector::class) | ||
| class FormatMoneyUseCaseTest { | ||
|
|
||
| private val features = mockk<Features>() | ||
| private val devicePreferences = mockk<DevicePreferences>() | ||
|
|
||
| enum class MoneyFormatterTestCase( | ||
| val amount: Double, | ||
| val showDecimal: Boolean, | ||
| val locale: Locale, | ||
| val expectedOutput: String | ||
| ) { | ||
| ENG_SHOW_DECIMAL( | ||
| amount = 1000.12, | ||
| showDecimal = true, | ||
| locale = Locale.ENGLISH, | ||
| expectedOutput = "1,000.12" | ||
| ), | ||
| ENG_HIDE_DECIMAL( | ||
| amount = 1000.12, | ||
| showDecimal = false, | ||
| locale = Locale.ENGLISH, | ||
| expectedOutput = "1,000" | ||
| ), | ||
| GERMAN_SHOW_DECIMAL( | ||
| amount = 1000.12, | ||
| showDecimal = true, | ||
| locale = Locale.GERMAN, | ||
| expectedOutput = "1.000,12" | ||
| ), | ||
| GERMAN_HIDE_DECIMAL( | ||
| amount = 1000.12, | ||
| showDecimal = false, | ||
| locale = Locale.GERMAN, | ||
| expectedOutput = "1.000" | ||
| ), | ||
| } | ||
|
|
||
| private lateinit var formatMoneyUseCase: FormatMoneyUseCase | ||
|
|
||
| @Test | ||
| fun `validate decimal formatting`( | ||
| @TestParameter testCase: MoneyFormatterTestCase | ||
| ): Unit = runBlocking { | ||
| // given | ||
| val context = mockk<Context>() | ||
| every { features.showDecimalNumber } returns mockk { coEvery { isEnabled(any()) } returns testCase.showDecimal } | ||
| every { devicePreferences.locale() } returns testCase.locale | ||
| formatMoneyUseCase = FormatMoneyUseCase(features, devicePreferences, context) | ||
|
|
||
| // when | ||
| val result = formatMoneyUseCase.format(value = testCase.amount) | ||
|
|
||
| // then | ||
| result shouldBe testCase.expectedOutput | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters