Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump g2 to 3.5.1 and g2tmpl to 1.13.0 in configs/containers/specs/jedi-ci.yaml #1261

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Aug 21, 2024

Summary

Yesterday's update of g2 and g2tmpl in configs/common/packages.yaml didn't make it into configs/containers/specs/jedi-ci.yaml. This PR fixes it.

Testing

  • No CI testing needed
  • Manual testing of containers using workflow_dispatch or nightly testing deferred to PR Update jedi container images. #1239, which overhauls the container builds for JEDI CI

Applications affected

JEDI CI

Systems affected

JEDI CI containers

Dependencies

n/a

Issue(s) addressed

Resolves #1260

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji requested a review from eap August 21, 2024 13:24
@climbfuji climbfuji self-assigned this Aug 21, 2024
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Aug 21, 2024
@climbfuji climbfuji marked this pull request as ready for review August 21, 2024 15:29
@climbfuji
Copy link
Collaborator Author

Note. Compile error of [email protected] with clang@14. Created an issue in the nceplibs-g2 repo with more information: NOAA-EMC/NCEPLIBS-g2#745

@climbfuji climbfuji mentioned this pull request Aug 21, 2024
2 tasks
Copy link
Collaborator

@eap eap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll merge the container spec manually.

@climbfuji climbfuji merged commit dfb069d into JCSDA:develop Aug 21, 2024
1 of 2 checks passed
@climbfuji climbfuji deleted the bugfix/jedi_ci_container_g2_g2tmpl branch August 21, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

CI container build broken following update of g2 and g2tmpl versions
2 participants