Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grep to linux tier2 site config to fix intel build errors [proposed change and discussion] #1418

Closed
wants to merge 1 commit into from

Conversation

eap
Copy link
Collaborator

@eap eap commented Dec 15, 2024

This is a proposed change to address the failing grep build observed when building with the intel legacy compiler and gcc-11.x. A log of the failure is included here: spack-stack-intel-grep-build-failure.txt. While this PR includes a specific fix by updating the linux.default site config, I'll outline several other options none of which seem much more satisfactory. I'm open to changing this PR if anyone can think of a compelling reason to use a different approach.

Fixes considered:

  • Update the linux.default site config to use an external build for grep [current proposal]
    • Pros: works for new site configs and integration tests
    • Cons: not compiler specific.
  • Update the configs/common/packages_intel.yaml to use an external package.
    • Pros: specific to intel,.
    • Cons: affects existing sites where this isn't an issue.
  • Update the integration test yaml to manually apply this fix.
    • Pros: Fixes tests,.
    • Cons: leaves this issue to be resolved manually for site-config creators.
  • Use spack external find grep.
    • Cons: spack is unable to find this package.

Testing

Manually tested on ubuntu and tested with CI.

Applications affected

N/A

Systems affected

New linux site configs.

Dependencies

This change is blocking #1416 (and possibly more).

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@eap eap added the INFRA JEDI Infrastructure label Dec 15, 2024
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunately not the way to do it. We don't know the version of grep on the system (even though it may not matter so much). For new site configs, the change must go into the "New Site Config" section of the documentation (doc/source/...) after verifying that the command spack external find --scope=system grep works (or after making it work). We should do that for macOS, too, while we are at it.

Lastly, we should add a list to the PR that adds the external grep to all tier-1 and tier-2 site configs (yes, in this case to packages.yaml, because these are specific systems).

@eap eap closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants