Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external grep package in GitHub actions, new site config instructions, and pre-configured tier-1 sites #1419

Merged
merged 16 commits into from
Dec 20, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Dec 16, 2024

Summary

External grep in new site configs (documentation), CI, Containers, pre-configured sites (at least tier 1).

Tier 1 (mandatory):

Tier 2 (optional):

  • blackpearl(@climbfuji)
  • bounty (@climbfuji)
  • casper (@climbfuji)
  • emc-rhel
  • frontera
  • linux.default in documentation (secion "New Site Config")
  • macos.default in documentation (secion "New Site Config")

Container recipes:

CI:

Testing

See above

Applications affected

None (external grep is a prerequisite for the upcoming GitHub CLI gh package).

Systems affected

All.

Dependencies

Issue(s) addressed

Working towards #1105

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji marked this pull request as ready for review December 16, 2024 14:34
@rickgrubin-tomorrow
Copy link

EPIC hosts

  • derecho
$ which grep
/usr/bin/grep

$ grep --version
grep (GNU grep) 3.1
  • gaea C5
$ which grep
/bin/grep
$ grep --version
grep (GNU grep) 3.1
  • gaea C6
$ which grep
/bin/grep
$ grep --version
grep (GNU grep) 3.1
  • hera
$ which grep
/usr/bin/grep

$ grep --version
grep (GNU grep) 3.1
  • hercules
$ which grep
/usr/bin/grep

$ grep --version
grep (GNU grep) 3.6
  • jet
$ which grep
/bin/grep

$ grep --version
grep (GNU grep) 3.1
  • noaa-aws
$ which grep
/usr/bin/grep

$ grep --version
grep (GNU grep) 3.1
  • noaa-azure
$ which grep
/usr/bin/grep

$ grep --version
grep (GNU grep) 3.1
  • noaa-gcloud
$ which grep
/usr/bin/grep

$ grep --version
grep (GNU grep) 3.1
  • orion
$ which grep
/usr/bin/grep

$ grep --version
grep (GNU grep) 3.6

@climbfuji climbfuji self-assigned this Dec 19, 2024
@climbfuji
Copy link
Collaborator Author

@AlexanderRichert-NOAA Can you please provide details on the OS grep on Acorn so that we can merge this PR? Thanks.

@climbfuji
Copy link
Collaborator Author

This PR is blocking other PRs. Can someone please review? If we don't get the external grep info for acorn before merging, I will create an issue to remind us to add that missing site config update later. Thanks!

Copy link
Collaborator

@rickgrubin-noaa rickgrubin-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@climbfuji climbfuji enabled auto-merge (squash) December 20, 2024 21:44
@climbfuji climbfuji merged commit 2173474 into JCSDA:develop Dec 20, 2024
9 checks passed
@climbfuji climbfuji deleted the feature/find_ext_grep branch December 21, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants