Fix: Don't polute global namespace with std. #1193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using namespace ...;
in a (especially a public) header file is bad form.props.hxx does collapse the std namespace into the global namespace which can lead to problems in client libraries.
Of course there may also be client code out there now that depends on this which would require that code to either add
std::
in some places or addusing namespace std
in the right places (which hopefully is inside another namespace or a compilation unit.