Better Typing for TerraDrawModes & Setting coordinatePrecision of modes inside of a TerraDraw to the respective Adapter #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesLMilner
requested changes
Dec 21, 2023
|
Hey @itoxiq - I reviewed PR, I think this is good with one small change. Unfortunately quite a few of the tests are now failing. If you want I can take a look at the tests, let me know your preference! |
JamesLMilner
approved these changes
Dec 22, 2023
| this.pointerDistance = (options && options.pointerDistance) || 40; | ||
|
|
||
| this.coordinatePrecision = (options && options.coordinatePrecision) || 9; | ||
| this.coordinatePrecision = 9; |
There was a problem hiding this comment.
I think was mean to be left as is? I will merge and make another small PR to remedy this to help move it along :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #136