Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the DEVELOPMENT guide to reference Node 18 LTS and npm 9 #95

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Update the DEVELOPMENT guide to reference Node 18 LTS and npm 9 #95

merged 1 commit into from
Oct 3, 2023

Conversation

jaiakash
Copy link
Contributor

@jaiakash jaiakash commented Oct 1, 2023

Fixes #92

@jaiakash jaiakash mentioned this pull request Oct 2, 2023
Closed
JamesLMilner
JamesLMilner reviewed Oct 2, 2023
View reviewed changes
Copy link
Owner

@JamesLMilner JamesLMilner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jaiakash. A few things here:

  • We don't need to do a release here so we will need to undo the changes in the CHANGELOG and changing the package.json version number.
  • There were grammatical and spelling changes to the README which is helpful, although for some reason the logo was changed?
  • To keep our change log clean, we'll need to get this into one nice commit message like docs: updated DEVELOPMENT to reference Node 18. These means we'll need to change the commit history. The easiest thing to do here is probably to do git reset HEAD~5 and then just commit the README with the logo reversion and the DEVELOPMENT.md file without the other changes.

Thanks again for your PR! Look forward to getting this in after these revisions.

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jaiakash
Copy link
Contributor Author

jaiakash commented Oct 3, 2023 •
edited
Loading

Hi, Sorry for the unnecessary changes. Thanks for the explanation. Have made the changes according to that.

@JamesLMilner JamesLMilner added hacktoberfest Tickets for participation in Hacktoberfest 2023 hacktoberfest-accepted Accepted hacktoberfest pull requests labels Oct 3, 2023
@JamesLMilner
Copy link
Owner

@jaiakash no problem! I'm glad the explanation was helpful :) This looks great and I can merge - thank you for your helpful contribution.

@JamesLMilner JamesLMilner merged commit c1512d7 into JamesLMilner:main Oct 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesLMilner JamesLMilner JamesLMilner left review comments

Assignees
No one assigned
Labels
hacktoberfest Tickets for participation in Hacktoberfest 2023 hacktoberfest-accepted Accepted hacktoberfest pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the DEVELOPMENT guide to reference Node 18 LTS and npm 9
2 participants
@jaiakash @JamesLMilner