Skip to content

Commit

Permalink
Make trivy scan tentative to overcome rate limits
Browse files Browse the repository at this point in the history
Related to aquasecurity/trivy-action#389

Signed-off-by: Oleksandr Porunov <[email protected]>
(cherry picked from commit 1dae22f)
  • Loading branch information
porunov committed Nov 5, 2024
1 parent c6107eb commit f380818
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions .github/workflows/ci-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,23 @@ jobs:
export JG_VER="$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)-$(git rev-parse --short HEAD)"
echo "JG_VER=${JG_VER}" >> $GITHUB_ENV
- name: Run Trivy vulnerability scanner
id: trivy_scan_step
if: github.repository == 'janusgraph/janusgraph'
uses: aquasecurity/[email protected]
# TODO: currently this step is tentative because of the rate-limiting issue.
# Thus, we add `continue-on-error: true` here, but we should remove it
# when either the issue is fixed (see: https://github.com/aquasecurity/trivy-action/issues/389)
# or we self-host trivy database.
uses: aquasecurity/[email protected]
continue-on-error: true
with:
image-ref: 'ghcr.io/janusgraph/janusgraph:${{ env.JG_VER }}${{ matrix.tag_suffix }}'
format: 'sarif'
output: 'trivy-results.sarif'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
ACTIONS_RUNTIME_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Upload Trivy scan results to GitHub Security tab
if: github.repository == 'janusgraph/janusgraph'
if: github.repository == 'janusgraph/janusgraph' && success() && steps.trivy_scan_step.outcome == 'success'
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: 'trivy-results.sarif'
Expand Down

1 comment on commit f380818

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: f380818 Previous: 213b754 Ratio
org.janusgraph.JanusGraphSpeedBenchmark.basicAddAndDelete 12377.209568284234 ms/op 12994.438964091325 ms/op 0.95
org.janusgraph.GraphCentricQueryBenchmark.getVertices 935.7472526197918 ms/op 957.3251909284766 ms/op 0.98
org.janusgraph.MgmtOlapJobBenchmark.runClearIndex 216.5061413471015 ms/op 216.45303196086957 ms/op 1.00
org.janusgraph.MgmtOlapJobBenchmark.runReindex 342.1779888583334 ms/op 342.81005004892853 ms/op 1.00
org.janusgraph.JanusGraphSpeedBenchmark.basicCount 250.91510749044105 ms/op 207.33680618088454 ms/op 1.21
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesAllPropertiesWithAllMultiQuerySlicesUnderMaxRequestsPerConnection 5022.0352495299285 ms/op 4953.295327365606 ms/op 1.01
org.janusgraph.CQLMultiQueryBenchmark.getElementsWithUsingEmitRepeatSteps 17211.47912542143 ms/op 16917.057558105356 ms/op 1.02
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesMultiplePropertiesWithSmallBatch 20293.868296817272 ms/op 18983.13907385985 ms/op 1.07
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.vertexCentricPropertiesFetching 58717.580647099996 ms/op 56527.85002600001 ms/op 1.04
org.janusgraph.CQLMultiQueryBenchmark.getAllElementsTraversedFromOuterVertex 8202.440580822968 ms/op 8433.13502817794 ms/op 0.97
org.janusgraph.CQLMultiQueryBenchmark.getVerticesWithDoubleUnion 388.5416603174512 ms/op 384.2152506805113 ms/op 1.01
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesAllPropertiesWithUnlimitedBatch 4169.2281560489055 ms/op 4227.1771161974975 ms/op 0.99
org.janusgraph.CQLMultiQueryBenchmark.getNames 8727.825068067881 ms/op 8339.221853925019 ms/op 1.05
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesThreePropertiesWithAllMultiQuerySlicesUnderMaxRequestsPerConnection 5928.6241246752825 ms/op 5604.356576582386 ms/op 1.06
org.janusgraph.CQLMultiQueryBenchmark.getLabels 7398.559729429357 ms/op 7082.884761983721 ms/op 1.04
org.janusgraph.CQLMultiQueryBenchmark.getVerticesFilteredByAndStep 435.3733157264347 ms/op 430.31039337061094 ms/op 1.01
org.janusgraph.CQLMultiQueryBenchmark.getVerticesFromMultiNestedRepeatStepStartingFromSingleVertex 12980.83645623381 ms/op 12459.636105572155 ms/op 1.04
org.janusgraph.CQLMultiQueryBenchmark.getVerticesWithCoalesceUsage 364.9879745873763 ms/op 357.5981502840734 ms/op 1.02
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesMultiplePropertiesWithAllMultiQuerySlicesUnderMaxRequestsPerConnection 15054.328636715474 ms/op 14793.559446997619 ms/op 1.02
org.janusgraph.CQLMultiQueryBenchmark.getIdToOutVerticesProjection 254.40610448925233 ms/op 245.84974412075837 ms/op 1.03
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesMultiplePropertiesWithUnlimitedBatch 15741.575385816617 ms/op 13806.414282860256 ms/op 1.14
org.janusgraph.CQLMultiQueryBenchmark.getNeighborNames 8457.282743168198 ms/op 8411.967305495045 ms/op 1.01
org.janusgraph.CQLMultiQueryBenchmark.getElementsWithUsingRepeatUntilSteps 9321.714321869576 ms/op 9104.974810254043 ms/op 1.02
org.janusgraph.CQLMultiQueryBenchmark.getAdjacentVerticesLocalCounts 8758.21165871486 ms/op 8793.398072298722 ms/op 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.