Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.6] Revert "Bump metrics.version from 4.2.19 to 4.2.20" #4038

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

li-boxuan
Copy link
Member

@li-boxuan li-boxuan commented Oct 6, 2023

This reverts commit 58294e4, which causes a few test failure consistently.


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

This reverts commit 58294e4.

Signed-off-by: Boxuan Li <[email protected]>
@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Oct 6, 2023
@li-boxuan
Copy link
Member Author

I'll merge this with CTR as this is simply a revert of dependency.

@li-boxuan li-boxuan merged commit b0e192d into JanusGraph:v0.6 Oct 7, 2023
57 checks passed
@li-boxuan li-boxuan deleted the 0.6-revert-metrics-bump branch October 7, 2023 06:55
@FlorianHockmann
Copy link
Member

My bad, the backport didn't just update from 4.2.19 to 4.2.20, but updated from 4.1.33 which indicates already that 4.2 is problematic for v0.6 as we then skipped backports for this dependency already earlier.
Sorry for the trouble and thanks for fixing this!

@li-boxuan li-boxuan added this to the Release v0.6.4 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: external Externally-managed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants