Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose BerkeleyJE configs [tp-tests] #4701

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

porunov
Copy link
Member

@porunov porunov commented Oct 17, 2024

This PR exposes all BerkeleyJE configuration options to users, so that they have better control over internal settings (this functionality was requested in #1623).
Overall there is a good discussion in #1623 about deadlocks and timeouts that BerkeleyJE storage backend has. Thus, I also skimmed through the comments as well as my past tests with BerkeleyJE and added potential configurations suggestions based on user's feedback in documentation that may help users to get started. That said, this configuration may not fix all the issues and most likely have it's own flaws.


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@porunov
Copy link
Member Author

porunov commented Oct 17, 2024

Lock timeout increase didn't help with BerkeleyJE tp-tests.
Thus, I opened a PR #4702 which reverts #4425 to fix tp-tests.
I will rebase this PR afterwards to add BerkeleyJE exposed configs to the user and also set lock-timeout back to the original value of 500 ms to not introduce any breaking changes.

@porunov porunov force-pushed the bugfix/berkeleyje-timeouts branch from 67ee2d2 to cb1a15d Compare October 18, 2024 03:22
@porunov porunov changed the title Expose BerkeleyJE configs and setup default lock timeout to 30 seconds [tp-tests] Expose BerkeleyJE configs [tp-tests] Oct 18, 2024
@porunov
Copy link
Member Author

porunov commented Oct 18, 2024

This PR now only exposes extra configs for BerkeleyJE. No breaking changes.

Related to JanusGraph#1623 and JanusGraph#4425

Signed-off-by: Oleksandr Porunov <[email protected]>
@porunov porunov force-pushed the bugfix/berkeleyje-timeouts branch from cb1a15d to f526efc Compare October 27, 2024 17:24
@porunov
Copy link
Member Author

porunov commented Oct 27, 2024

Merging this PR following lazy consensus

@porunov porunov merged commit e849077 into JanusGraph:master Oct 27, 2024
184 of 185 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant