-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More flexible trigger bit usage #138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
baltzell
commented
Nov 2, 2023
- indent/format and remove unused imports, variables, non-helpful comments
- RG-D address trigger bits
baltzell
force-pushed
the
trigger-bits
branch
from
November 2, 2023 21:42
8962ba8
to
d301df6
Compare
7 tasks
c-dilks
reviewed
Nov 3, 2023
c-dilks
reviewed
Nov 3, 2023
monitoring/src/main/java/org/jlab/clas12/monitoring/monitor2p2GeV.java
Outdated
Show resolved
Hide resolved
monitoring/src/main/java/org/jlab/clas12/monitoring/monitor2p2GeV.java
Outdated
Show resolved
Hide resolved
monitoring/src/main/java/org/jlab/clas12/monitoring/monitor2p2GeV.java
Outdated
Show resolved
Hide resolved
baltzell
force-pushed
the
trigger-bits
branch
from
November 10, 2023 20:49
e9bbdf8
to
74ff3ef
Compare
Ok, running one last test, then good to go. |
baltzell
force-pushed
the
trigger-bits
branch
from
November 13, 2023 17:41
74ff3ef
to
27d7b89
Compare
Tested succesfully, ready to merge. |
c-dilks
approved these changes
Nov 13, 2023
…GeV.java Co-authored-by: Christopher Dilks <[email protected]>
c-dilks
force-pushed
the
trigger-bits
branch
from
November 13, 2023 18:29
27d7b89
to
94ef928
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.