Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible trigger bit usage #138

Merged
merged 8 commits into from
Nov 13, 2023
Merged

More flexible trigger bit usage #138

merged 8 commits into from
Nov 13, 2023

Conversation

baltzell
Copy link
Contributor

@baltzell baltzell commented Nov 2, 2023

  • indent/format and remove unused imports, variables, non-helpful comments
  • RG-D address trigger bits

@baltzell baltzell marked this pull request as ready for review November 2, 2023 21:42
@baltzell baltzell requested a review from c-dilks November 2, 2023 21:42
@forcar
Copy link

forcar commented Nov 2, 2023

For the trigger ratio histos I mentioned the denominator of the ratio is made below in processEvent, so these should also use testTriggerSector:

Screenshot 2023-11-02 at 7 39 34 PM

@c-dilks c-dilks added this to the SWIF Integration milestone Nov 3, 2023
@baltzell
Copy link
Contributor Author

Ok, running one last test, then good to go.

@baltzell
Copy link
Contributor Author

Tested succesfully, ready to merge.

@c-dilks c-dilks enabled auto-merge (squash) November 13, 2023 18:29
@c-dilks c-dilks merged commit d45e6bd into main Nov 13, 2023
10 checks passed
@c-dilks c-dilks deleted the trigger-bits branch November 13, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants