Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw hits on Si clusters in Tracker2DHitProcessor #170

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rodwyer100
Copy link
Contributor

Similarly to the problem observed in the creation of the FSPParticle object, if we want to include clusters in an ntupple for our analysis the asssociated processor, Trcker2DHitProcessor, has empty pointers to the rawhits inside of the cluster object it puts in your output root file. Cam wanted to do a speed run of how fast he could write it :), so now we have this version of the Tracker2DHitProcessor with populated clusters. I will include in this push request below a record of the validation tests I performed to see if it was worthy to be put into master.

@rodwyer100
Copy link
Contributor Author

First my SvtRawDataAnaProcessor.cxx (the code we use to analyze pulse times) was geared to check whether a hit existed within a cluster so that we can clean up some plots (and only plot distributions for hits that could possibly be associated with a track). I put a couple print statements in the portion that opened clusters and raw hits. These print statements looked like "Do I go here" and "Do I go here" indicating that the processor could access a cluster collection, and then for each associated cluster whether it could access the raw hits therein. Before Cam's work I only saw this first one, and after the second. That second can only occur if the pointers to raw hits in each cluster was populated with a raw hit, so this should be sufficient evidence that it is doing what it should be doing.

image

I was also asked to run valgrind on this piece of code. I will comment its output in the next comment.

@rodwyer100
Copy link
Contributor Author

Here is that result:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants