-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotated pion detector system #538
Open
Elhamm1
wants to merge
621
commits into
JeffersonLab:main
Choose a base branch
from
Elhamm1:RotatedPionDetectorSystem
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Locating map files correctly
…pdate modified collimator 5 to avoid interception with moller particles
…equal-lead-concrete-radius Bugfix: allow unequal lead/concrete radii for pion donut
Bringing feature-modified-upstream-shield branch up-to-date with develop
The `-latest` targets change without notice (if you're not paying attention).
…-rid-of-pointers Turn most messenger pointers into objects
…target-when-no-sampling-volume return default vertex when no target volume specified
Load material G4_Galactic only when needed
…-macos-10.15-ubuntu-20.04 workflows: ubuntu-20.04 and macos-10.15
…mult-scatt Bugfix beam target mult scatt
…as-object-in-primary-generator Bugfix: beam target as object in primary generator
…omentumForPhysGen Bugfix: Use real momentum for physics generators instead of true momentum
Update showermax
clang-tidy static analysis with cmake -DENABLE_CLANG_TIDY=ON
…upstream of collimator 1. Previously its z location overlapped with coll1, which wouldn't work during the experiment because we want to be able to slide the sieve in and out of the beamline along the x axis.
Update the sieve position in the z axis so that it is 10cm upstream of collimator 1
… This includes punch through the sieve and blocker.
…the names of the scripts do not contain special characters.
…locker thickness.
…d, they specify a 90mm sieve or blocker.
This will add scripts that I have made for the Punch Through Studies.
…particles, extending inner radial shielding to 10 inches, and adding a 10 inches outer radial shielding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rotating pion detector system to suppress background from low energy particles.
Extending the inner radial shielding from 1.8 inches to 10 inches to cover the whole detector.
Adding a 10 inches outer radial shielding to cover the pion detector system in the outer radial edge.