-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(utils): calldatacopy argument heuristics #440
base: main
Are you sure you want to change the base?
feat(utils): calldatacopy argument heuristics #440
Conversation
…rgument-heuristic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally got a chance to take a look, looks pretty good overall! there is a bit more needed to the implementation i think, since decompiling seaport 0x00000000000000adc04c56bf30ac9d3c0aaf14dc gives a lot of nonsense (most functions end up having like 20 args D:)
i think calculating arg_index needs to change for both CALLDATALOAD and CALLDATACOPY with a more sophisticated mapping calculation, since CALLDATACOPY can span multiple words and this will throw the calculations off
i'll probably add a few commits trying to address this soonish
Motivation
Targets #379
Solution