printing with styled/non-unit-textwidth-character contents #443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, BlockArrays with elements that used styling would throw off the printing, because the textwidth computation didn't account for the fact that some contents might have a different
length
relative to how much space they take up when printed.This fixes that by using the
ANSIIterator
from Base, ala JuliaLang/julia#47430. Unfortunately,ANSIIterator
isn't exported at the moment - but the alternative is to depend on StringManipulations.jl or copy over the Base implementation.I added a test that shows the problem. Previously, it displayed as:
With this, it displays as: