Add LinuxPerf extension for branch + instruction counts
#375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
force-pushed
the
ct/LinuxPerf-ext
branch
3 times, most recently
from
e526c5d to
0b21870
Compare
topolarity
force-pushed
the
ct/LinuxPerf-ext
branch
from
f704993 to
2bedf53
Compare
topolarity
force-pushed
the
ct/LinuxPerf-ext
branch
from
2bedf53 to
21ca9cd
Compare
This updates the core BenchmarkTools types to include `instructions` and `branches` fields. These fields support serialization and all of the usual stats / judgements via the Trial / TrialEstimate / TrialRatio interface. If the extension is not available or `perf` is not configured correctly on your system, these are `NaN`. This also keeps the serialization format backwards-compatible, reporting any missing measurements as `NaN`.
topolarity
force-pushed
the
ct/LinuxPerf-ext
branch
from
21ca9cd to
9be1101
Compare
|
It'd be good to get some feedback on this (cc @vchuravy) I'd really like to get cycle counts into our nanosoldier reports - the wall time measurements are quite noisy |
giordano
reviewed
Dec 19, 2024
| @@ -22,7 +28,8 @@ Profile = "<0.0.1, 1" | |||
| Statistics = "<0.0.1, 1" | |||
| Test = "<0.0.1, 1" | |||
| UUIDs = "<0.0.1, 1" | |||
| julia = "1.6" | |||
| julia = "1.9" | |||
| LinuxPerf = ">= 0.4" | |||
There was a problem hiding this comment.
This type of unbound specifiers aren't accepted in the registry
Suggested change
| LinuxPerf = ">= 0.4" | |
| LinuxPerf = "0.4" |
Sounds reasonable to me - apparently on Skylake the cycle counter has a dedicated counter too, so it shouldn't cause more PMU muxing if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a straightforward extension for
LinuxPerfand updates the coreTrial/TrialEstimate/ etc. types to include "instructions" and "branches" fields, with the usual stats + serialization + judgement support.If
LinuxPerfis not loaded, instruction/branch counts are returned asnothingfrominstructions(t),branches(t), etc. (internally they are stored asNaN)This is an alternative to #347, which tries to provide a fully-generic interface. In contrast, this PR focuses on updating the core datatypes to make room for instruction / branch counts and LinuxPerf is just one possible source for those counts.