-
Notifications
You must be signed in to change notification settings - Fork 482
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed docstring collapse/expand icon not changing when clicking rapid…
…ly (#2217)
- Loading branch information
Showing
7 changed files
with
121 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,57 +1,72 @@ | ||
| // libraries: jquery | ||
| // arguments: $ | ||
|
|
||
| let timer = 0; | ||
| var isExpanded = true; | ||
|
|
||
| $(document).on("click", ".docstring header", function () { | ||
| let articleToggleTitle = "Expand docstring"; | ||
|
|
||
| if ($(this).siblings("section").is(":visible")) { | ||
| $(this) | ||
| .find(".docstring-article-toggle-button") | ||
| .removeClass("fa-chevron-down") | ||
| .addClass("fa-chevron-right"); | ||
| } else { | ||
| $(this) | ||
| .find(".docstring-article-toggle-button") | ||
| .removeClass("fa-chevron-right") | ||
| .addClass("fa-chevron-down"); | ||
| debounce(() => { | ||
| if ($(this).siblings("section").is(":visible")) { | ||
| $(this) | ||
| .find(".docstring-article-toggle-button") | ||
| .removeClass("fa-chevron-down") | ||
| .addClass("fa-chevron-right"); | ||
| } else { | ||
| $(this) | ||
| .find(".docstring-article-toggle-button") | ||
| .removeClass("fa-chevron-right") | ||
| .addClass("fa-chevron-down"); | ||
|
|
||
| articleToggleTitle = "Collapse docstring"; | ||
| } | ||
| articleToggleTitle = "Collapse docstring"; | ||
| } | ||
|
|
||
| $(this) | ||
| .find(".docstring-article-toggle-button") | ||
| .prop("title", articleToggleTitle); | ||
| $(this).siblings("section").slideToggle(); | ||
| $(this) | ||
| .find(".docstring-article-toggle-button") | ||
| .prop("title", articleToggleTitle); | ||
| $(this).siblings("section").slideToggle(); | ||
| }); | ||
| }); | ||
|
|
||
| $(document).on("click", ".docs-article-toggle-button", function () { | ||
| let articleToggleTitle = "Expand docstring"; | ||
| let navArticleToggleTitle = "Expand all docstrings"; | ||
|
|
||
| if (isExpanded) { | ||
| $(this).removeClass("fa-chevron-up").addClass("fa-chevron-down"); | ||
| $(".docstring-article-toggle-button") | ||
| .removeClass("fa-chevron-down") | ||
| .addClass("fa-chevron-right"); | ||
| debounce(() => { | ||
| if (isExpanded) { | ||
| $(this).removeClass("fa-chevron-up").addClass("fa-chevron-down"); | ||
| $(".docstring-article-toggle-button") | ||
| .removeClass("fa-chevron-down") | ||
| .addClass("fa-chevron-right"); | ||
|
|
||
| isExpanded = false; | ||
| isExpanded = false; | ||
|
|
||
| $(".docstring section").slideUp(); | ||
| } else { | ||
| $(this).removeClass("fa-chevron-down").addClass("fa-chevron-up"); | ||
| $(".docstring-article-toggle-button") | ||
| .removeClass("fa-chevron-right") | ||
| .addClass("fa-chevron-down"); | ||
| $(".docstring section").slideUp(); | ||
| } else { | ||
| $(this).removeClass("fa-chevron-down").addClass("fa-chevron-up"); | ||
| $(".docstring-article-toggle-button") | ||
| .removeClass("fa-chevron-right") | ||
| .addClass("fa-chevron-down"); | ||
|
|
||
| isExpanded = true; | ||
| articleToggleTitle = "Collapse docstring"; | ||
| navArticleToggleTitle = "Collapse all docstrings"; | ||
| isExpanded = true; | ||
| articleToggleTitle = "Collapse docstring"; | ||
| navArticleToggleTitle = "Collapse all docstrings"; | ||
|
|
||
| $(".docstring section").slideDown(); | ||
| } | ||
| $(".docstring section").slideDown(); | ||
| } | ||
|
|
||
| $(this).prop("title", navArticleToggleTitle); | ||
| $(".docstring-article-toggle-button").prop("title", articleToggleTitle); | ||
| $(this).prop("title", navArticleToggleTitle); | ||
| $(".docstring-article-toggle-button").prop("title", articleToggleTitle); | ||
| }); | ||
| }); | ||
|
|
||
| function debounce(callback, timeout = 300) { | ||
| if (Date.now() - timer > timeout) { | ||
| callback(); | ||
| } | ||
|
|
||
| clearTimeout(timer); | ||
|
|
||
| timer = Date.now(); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.