Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tracefiles for coverage #49

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Use tracefiles for coverage #49

merged 6 commits into from
Oct 23, 2023

Conversation

goerz
Copy link
Member

@goerz goerz commented Oct 16, 2023

This is to avoid .cov files cluttering the src directory.

I'm opening this PR to test how it runs in the CI and whether the coverage information is correctly submitted to Codecov

@goerz goerz force-pushed the mg/tracefile branch 4 times, most recently from 681c503 to a4f0378 Compare October 16, 2023 21:30
@goerz
Copy link
Member Author

goerz commented Oct 16, 2023

For clarification: This uses a single tracefile.info when testing locally (via make test or by running test() in the development REPL). On CI, the more traditional --code-coverage="user" is still used, which produces .cov files in the src folder. I got the impression the julia-actions/julia-processcoverage works better with (only with?) .cov files. Also, we don't really care about "littering" on the CI system.

@IanButterworth
Copy link

I recommend not using --code-coverage="user" but instead use the --code-coverage=@{path to repo} because user tests all non-Base code, including stdlibs. @ path approach will be much faster

@IanButterworth
Copy link

I forgot to mention it won't work on 1.6, so you may want to pass user or @ in via a matrix or something

@goerz goerz force-pushed the mg/tracefile branch 10 times, most recently from 444288a to e9971cb Compare October 17, 2023 02:01
@goerz
Copy link
Member Author

goerz commented Oct 17, 2023

Yeah, I've been trying that, but Github apparently doesn't allow using matrix values either inside the shell: or if: values for a step.

@goerz goerz force-pushed the mg/tracefile branch 6 times, most recently from 7a38480 to 1baf392 Compare October 17, 2023 03:02
@goerz
Copy link
Member Author

goerz commented Oct 17, 2023

Well, splitting it into two jobs (test and testnocov) does the trick.

I'm going to get rid of macOS testing, too. It fails (hangs) about 10% of the time, and it's really not necessary. First, I'm developing on macOS, so it's getting plenty of testing. Second, I've never seen something work on Linux and fail on macOS.

@goerz goerz force-pushed the mg/tracefile branch 4 times, most recently from 589e281 to 91882e5 Compare October 17, 2023 16:02
@goerz goerz force-pushed the mg/tracefile branch 6 times, most recently from ef0a1ec to d192690 Compare October 17, 2023 18:33
@goerz goerz merged commit 138f9be into master Oct 23, 2023
3 of 5 checks passed
@goerz goerz deleted the mg/tracefile branch October 25, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants