Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to BinaryBuilder #173

Merged
merged 1 commit into from
Apr 7, 2018
Merged

switch to BinaryBuilder #173

merged 1 commit into from
Apr 7, 2018

Conversation

stevengj
Copy link
Contributor

@stevengj stevengj commented Apr 7, 2018

Using the https://github.com/JuliaInterop/ZMQBuilder repo.

Closes #168, closes #164, closes #162, closes #151, closes #137, closes #133, closes #92, closes #45, closes #40.

@stevengj
Copy link
Contributor Author

stevengj commented Apr 7, 2018

AppVeyor failure on 0.7 should be fixed when a new BinaryProvider is tagged, I think.

@stevengj
Copy link
Contributor Author

stevengj commented Apr 7, 2018

This temporarily eliminates FreeBSD support, but this was added only recently (#171) and was never present in any tagged release. That should be fixed in the near future once BinaryBuilder adds that platform (JuliaPackaging/BinaryBuilder.jl#215).

@stevengj stevengj merged commit 80625fb into master Apr 7, 2018
@stevengj stevengj deleted the bbuilder branch April 7, 2018 14:07
@marius311
Copy link

I believe this also eliminated MUSL support. Any chance that could be brought back?

I had been creating lightweight Alpine-based Docker containers to run Jupyter notebooks on mybinder.org, and this no longer seems to work because of this (since Alpine is MUSL-based and Jupyter needs ZMQ)

@stevengj
Copy link
Contributor Author

The latest BinaryBuilder supports musl as well as BSD etc:

https://github.com/JuliaPackaging/BinaryBuilder.jl/blob/v0.0.3/src/RootFS.jl#L120-L141

So, we just need to update ZMQBuilder to use these and push a new tag.

@stevengj
Copy link
Contributor Author

Just pushed a new commit to ZMQBuilder, and it is building now. Once Travis passes, I can tag it to get the build products and then update ZMQ.jl.

@marius311
Copy link

Thanks for the quick reply! Incidentally, it would be great if you could do the same for Blosc (although that's less critical for me)

@stevengj
Copy link
Contributor Author

Yes, I just pushed something to BloscBuilder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment