-
-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved tooltip: functions, tuples, etc #847
base: master
Are you sure you want to change the base?
Conversation
Would be good to add a |
I agree that it would be nice to use the Julia parser; the basic issue is that the user might be asking for help on code they haven't finished writing yet… |
I will try quickly adding some test cases. It's the first time I develop Julia packages so I will need to check out some docs... |
I have changed behavior slightly to make sure the basic |
As a note, the julia tokenizer might be helpful for a better solution: |
Do you have any plan on merging? I think the current state is good enough for an intermediate improvement. |
Any updates? |
Any activities on this? @stevengj can this be merged, or are there some feedback? |
Any more reviews? |
Do you think this is mergable or is it too hacky to be put into mainline? I have been waiting for a decision for quite a while. |
Is there anything I still need to do? Or is this superseded by some other patches? |
This is an attempt to fix #631.
I have implemented the behavior specified in the issue, allowing tooltip for
f
when Shift-Tab is pressed inside a function callf(x, y, ... |)
or right outside the callf(x, y, ...)|
.|
is cursor. Detailed behavior is in docstring.The current implementation has some string hacks which I consider ugly (explained thoroughly, I hope, in docstrings). If I can dig deeper, I prefer an implementation using a proper Julia language parser. Maybe one that comes from Julia itself.
In any case, I tested with quite a few of my Notebooks, and they all seem to work well.
I forgot to squash the commits, though.