Remove * for Adjoint of Givens #41190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one also caused a method ambiguity for me so I wonder if it is also obsolete for the same reasons as the other ones in this PR? There are a dozen lines more at the end of the file that look dubious too...
|
I believe this one is necessary, because in line 58 we have adjoint(R::Rotation) = Adjoint(R)and |
|
Apologies - I see now that the real "issue" here for me is that an So I will resolve my method ambiguity for this one by throwing an error. I'll close this PR. Thanks! |
|
No worries! I took the opportunity to start hunting for more of these spurious methods with types that cannot be constructed from calling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one also caused a method ambiguity for me so I wonder if it is also obsolete for the same reasons as the other ones in this PR?
There are a dozen lines more at the end of the file that look dubious too...