-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for MMTk (non-moving immix) #56288
base: master
Are you sure you want to change the base?
Conversation
5257d4a
to
4621e5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First review pass.
Will follow-up with more comments soon.
3e68f3c
to
6a01c26
Compare
6a01c26
to
bc08a9b
Compare
167c10f
to
c6fd2d9
Compare
In any case, I had to restart PkgEval, so re-triggering: @nanosoldier |
The package evaluation job you requested has completed - possible new issues were detected. |
2567f15
to
dc89ced
Compare
From discussion: We should not block this PR on a PkgEval run w/ MMTk. If we are happy w/ the PkgEval results from this PR with stock GC, this should be ready to merge. This PR is just a refactoring and introducing a new GC behind a flag. It could be that literally nothing works with the MMTk GC, and that's fine - we will iterate in future PRs. This PR is just to get the new GC option in, and unit tests passing, to keep it stable. I'm still interested in doing that PkgEval with MMTk, but IMO that should be a follow-up step (which you could drive from a separate PR). EDIT: To be clear, we should not put this in release notes or advertise it to users, nor make any stability claims, until we've run PkgEval and much more! But just merging this first step is totally fine. |
ef16f55
to
5c7dfd5
Compare
@nanosoldier runtests(["EarlyStopping", "Malt", "NearestNeighbors", "BPGates", "IMFData", "NCEI", "OptimizationPRIMA", "JUDI", "TaylorIntegration", "KolmogorovArnold", "DynamicalSystemsBase", "DiffEqDevTools", "MicroCanonicalHMC", "CellMLToolkit", "FlightSims", "SpiDy", "QuantumAnnealing", "Modia", "MRIgeneralizedBloch", "SideKicks"]) |
"Malt", and "NearestNeighbors" are clear. Gabriel and I were seeing semi-random segfaults on them on nightly. |
Good to know. I commented again because I'm not sure it actually triggered a rerun. Do I need specific privileges to run PkgEval? |
yes, and it also needs the back ticks |
5c7dfd5
to
8edf616
Compare
The package evaluation job you requested has completed - no new issues were detected. |
8edf616
to
27c5480
Compare
PkgEval came back fully clean. |
The package evaluation job you requested has completed - no new issues were detected. |
82826ef
to
5644e19
Compare
* Adding makefile support for building with mmtk
5644e19
to
4b415c4
Compare
This PR adds the possibility of building/running Julia using MMTk, running non-moving immix.
The binding code (Rust) associated with it is in https://github.com/mmtk/mmtk-julia/tree/upstream-ready/immix. Instructions on how to build/run Julia with MMTk are described in the
README
file inside the binding repo.