Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Markdown.parse public #56818

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

make Markdown.parse public #56818

wants to merge 2 commits into from

Conversation

matthias314
Copy link
Contributor

This has been discussed on Discourse.

I've split the PR into 3 commits:

  • one for making parse public and documenting the public methods,
  • one for renaming the non-public methods to _parse,
  • one for also making the Markdown flavors public.

This way you can more easily decide what to take and what not.

@matthias314 matthias314 changed the title make 'Markdown.parse` public make Markdown.parse public Dec 13, 2024
@nsajko nsajko added stdlib Julia's standard library markdown labels Dec 13, 2024
@matthias314
Copy link
Contributor Author

I've removed the third commit. Now flavors are not documented anymore. Hopefully the PR can now be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

@mortenpi mortenpi mortenpi left review comments

Assignees
No one assigned
Labels
markdown stdlib Julia's standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthias314 @mortenpi @fredrikekre @nsajko