Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Base.@acquire for non-closure version of Base.acquire(f, s::Base.Semaphore) #56845

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add Base.@acquire for non-closure version of Base.acquire(f, s::Base.Semaphore) #56845

wants to merge 3 commits into from

Conversation

IanButterworth
Copy link
Member

Given @lock exists, this would make sense.

IanButterworth
IanButterworth commented Dec 16, 2024
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@nsajko nsajko added multithreading Base.Threads and related functionality feature Indicates new feature / enhancement requests labels Dec 16, 2024
@nsajko
Copy link
Contributor

nsajko commented Dec 16, 2024

Is this purely intended as a workaround for #15276 in the context of usage of acquire?

If so, IMO it's redundant with the more general workaround of adding a let around the closure definition, as described in the Performance Tips.

ararslan
ararslan reviewed Dec 16, 2024
View reviewed changes
base/lock.jl Outdated Show resolved Hide resolved
base/lock.jl Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan left review comments

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
feature Indicates new feature / enhancement requests multithreading Base.Threads and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IanButterworth @nsajko @quinnj @ararslan