simplify and slightly improve memorynew inference #56857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while investigating some missed optimizations in #56847, @gbaraldi and I realized that
copy(::Array)
was usingjl_genericmemory_copy_slice
rather than thememmove
/jl_genericmemory_copyto
thatcopyto!
lowers to. This version lets us use the faster LLVM based Memory initialization, and the memove can theoretically be further optimized by LLVM (e.g. not copying elements that get over-written without ever being read).We also optimize the
memorynew
type inference to make it so that getting the length of a memory with known length will propagate that length information (which is important for cases likesimilar
/copy
etc).