Don't cast indices to Int
in isassigned
call while displaying arrays
#56863
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment on the line says that
isassgined
requiresInt
indices, but this isn't correct: it accepts arbitraryInteger
indices. The corresponding methods are defined inmultidimensional.jl
. E.g.:We may therefore pass the indices to the call directly without converting them to
Int
s. This helps for huge arrays, where the indices may lie outside the bounds ofInt
, but are otherwise valid.As an example, the following would work correctly after this, whereas displaying the array errors currently: