Switch debug registry mapping to CodeInstance
#56878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Dec 20, 2024
Comment on lines
+146
to
+148
| if isa(def, Core.ABIOverride) | ||
| def = def.def | ||
| end |
There was a problem hiding this comment.
The arbitrary proliferation of these checks seems a bad sign, but that is unrelated to this PR (which looks good to me)
There was a problem hiding this comment.
Yeah, we just need to put these behind a better accessor. I'll clean that up in the future.
Keno
added a commit
to timholy/Revise.jl
that referenced
this pull request
Dec 20, 2024
The `linfo` field of `StackFrame` can now be a `CodeInstance`.
Keno
added a commit
to timholy/Revise.jl
that referenced
this pull request
Dec 21, 2024
Currently our debugging code maps from pointers to `MethodInstance`. However, I think it makes more sense to map to `CodeInstance` instead, since that's what we're actually compiling and as we're starting to make more use of external owners and custom specializations, we'll want to be able to annotate that in backtraces. This only adjusts the internal data structures - any actual printing changes for those sorts of use cases will have to come separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our debugging code maps from pointers to
MethodInstance. However, I think it makes more sense to map toCodeInstanceinstead, since that's what we're actually compiling and as we're starting to make more use of external owners and custom specializations, we'll want to be able to annotate that in backtraces. This only adjusts the internal data structures - any actual printing changes for those sorts of use cases will have to come separately.