fix: Base.GMP.MPZ.invert yielding return code instead of return value #56894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NegaScout
changed the title
giordano
added
bignums
|
It'd be good to add a regression test |
thofma
reviewed
Dec 23, 2024
base/gmp.jl
Outdated
| invert!(x::BigInt, b::BigInt) = invert!(x, x, b) | ||
| function invert(a::BigInt, b::BigInt) | ||
| ret = deepcopy(a) |
There was a problem hiding this comment.
Suggested change
| ret = deepcopy(a) | |
| ret = BigInt() |
A deepcopy is a bit excessive.
P.S.: Alternatively you can fix the invert!(x::BigInt, a::BigInt, b::BigInt) function to return x.
There was a problem hiding this comment.
I dont think I can without also refactoring invmod(x::BigInt, y::BigInt) at line 519
There was a problem hiding this comment.
However I modified the original commit in shorter notation without the deepcopy
There was a problem hiding this comment.
Alternatively you can fix the
invert!(x::BigInt, a::BigInt, b::BigInt)function to returnx.
Initially I agreed, but looking at invmod, I see that there still needs to be a way to get the return code and the return value is the cleanest way I can think of.
NegaScout
force-pushed
the
jw/variable_names_refactor
branch
from
e4c2c59 to
00cda38
Compare
giordano
reviewed
Dec 23, 2024
NegaScout
force-pushed
the
jw/variable_names_refactor
branch
from
9eb202f to
bb79ec4
Compare
NegaScout
changed the title
LilithHafner
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I hope I followed all guidelines for contributing, this is my first contribution.
There is a bug in
Base.GMP.MPZ.invertit returns GMP return code, instead of the actual value. This PR fixes it. I am not sure if it could be implemented better, but from my testing you cannot get away without a deepcopy.Before:
After: